Create HTML templates for modals #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmaa
reviewed
Sep 17, 2024
Unlike HTML, the CSS for modal Figuring out all the CSS used for modals may be out of scope of this PR. It requires extracting modals CSS into 2 files |
Casheeew
approved these changes
Oct 4, 2024
austinyu12
pushed a commit
to austinyu12/yomitan
that referenced
this pull request
Oct 22, 2024
* reuse modals * refactor * only load templates when needed * lint * shared-modals * lint * type * lint * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1419
Add loading template modals for
ModalControllerfrom a list of template names.Currently having 2 templates (which should have better naming)
welcome-modals: Modals shared between welcome and settings page.settings-modals: Modals in settings page onlyIf this is too vague then we can refactor to multiple templates where each contains a group of modals for a specific setting like:
profile-modals,custom-css-modals,anki-cards-modals, etc. then each page will load the required templates.